Skip to content

Fix false positive for delegate #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Conversation

rjmurillo
Copy link
Owner

When a delegate is used but not combined or passed around, ECS0700 was triggered. There is no problematic behavior. See #54 for details.

Resolves #54

When a delegate is used but not combined or passed around, ECS0700 was triggering. There is no problematic behavior. See #54 for details
@rjmurillo rjmurillo added this to the v0.1.0 milestone Aug 15, 2024
@rjmurillo rjmurillo self-assigned this Aug 15, 2024
@rjmurillo rjmurillo enabled auto-merge (squash) August 15, 2024 21:18
@rjmurillo rjmurillo added bug Something isn't working analyzers labels Aug 15, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.11% (target: -1.00%) 94.12%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (28d90a7) 811 735 90.63%
Head commit (1c24491) 821 (+10) 745 (+10) 90.74% (+0.11%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#55) 17 16 94.12%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@rjmurillo rjmurillo merged commit ec3c655 into release/v0.1.0 Aug 16, 2024
8 checks passed
@rjmurillo rjmurillo deleted the bug/54-fp-ecs0700 branch August 16, 2024 17:27
rjmurillo added a commit that referenced this pull request Aug 16, 2024
rjmurillo added a commit that referenced this pull request Aug 19, 2024
When a delegate is used but not combined or passed around, ECS0700 was
triggered. There is no problematic behavior. See #54 for details.

Resolves #54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzers bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive: ECS0700 incorrectly detects usage of delegates when no dangerous patterns occur
1 participant